search

hugues-m / phpunit-vw

VW PHPUnit extension makes your failing test cases succeed under CI tools scrutiny
MIT License
1.75k stars 37 forks source link

Update .gitignore #9

Closed OHB closed 8 years ago

OHB commented 8 years ago

One should not .gitignore composer.lock

OskarStark commented 8 years ago

:+1:

fabiang commented 8 years ago

This PR is against the principles of this extension: avoid unnecessary errors like "Warning: The lock file is not up to date with the latest changes in composer.json"

fabiang commented 8 years ago

< no_sarcasm >And if you do so, you should run composer update instead of composer install in your .travis.yml</ no_sarcasm >

hugues-m commented 8 years ago

I don't think composer.lock should be versioned for components as it will be set for the application depending on them. This component should be built/tested with all relevant X.Y versions of PHPUnit (using Travis build matrix), so no need to lock the versions. #todo It does not take much time for contributors to install the dependencies and require less maintenance, :-1: for me.
Thanks anyway!

fabiang commented 8 years ago

http://slides.seld.be/?file=2014-10-23+Composer+Best+Practices.html#36

OHB commented 8 years ago

Well forgive me for attempted to put world-wide best practices into use here.