search

hugues31 / coinnect

Coinnect is a Rust library aiming to provide a complete access to main crypto currencies exchanges via REST API.
MIT License
148 stars 43 forks source link

Use RustCrypto instead of rust-crypto #33

Closed newpavlov closed 7 years ago

newpavlov commented 7 years ago

As I see you only use SHA-2 and HMAC, so you don't need the whole rust-crypto (moreover it's not developed anymore). Instead you can use crates from RustCrypto organization which is a modular rework of rust-crypto. In addition to smaller size, those crates are written in completely pure Rust.

hugues31 commented 7 years ago

Definitely a good idea, thanks :) I will send a PR in the week if I do not encounter any problem.

ainestal commented 7 years ago

+1

On 18 July 2017 at 17:08, hugues31 notifications@github.com wrote:

Definitely a good idea, thanks :) I will send a PR in the week if I do not encounter any problem.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hugues31/coinnect/issues/33#issuecomment-316113790, or mute the thread https://github.com/notifications/unsubscribe-auth/AD_WWT4MU46UJ941RZ-YcQcalhig4apAks5sPNhigaJpZM4ObPEa .

-- Alejandro Inestal García

newpavlov commented 7 years ago

@hugues31 Feel free to ask any questions! Although I think HMAC section in the readme should be enough to start.

hugues31 commented 7 years ago

Thanks. I already made the transition for Kraken, I will finish later this afternoon :)