search

hugues31 / coinnect

Coinnect is a Rust library aiming to provide a complete access to main crypto currencies exchanges via REST API.
MIT License
147 stars 43 forks source link

Replace rust crypto crate #34

Closed hugues31 closed 7 years ago

hugues31 commented 7 years ago

I think everything works fine since tests passed but I don't have any Bitstamp Credentials to run the private tests relative to this exchange. Close #33

ainestal commented 7 years ago

Don't worry, I will run them this evening

On 19 July 2017 at 12:50, hugues31 notifications@github.com wrote:

I think everything works fine since tests passed but I don't have any Bitstamp Credentials to run the private tests relative to this exchange. Close #33 https://github.com/hugues31/coinnect/issues/33

You can view, comment on, or merge this pull request online at:

https://github.com/hugues31/coinnect/pull/34 Commit Summary

  • Replace unmaintened rusts-crypto to the pure Rust crate RustCrypto
  • Bump version

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hugues31/coinnect/pull/34, or mute the thread https://github.com/notifications/unsubscribe-auth/AD_WWYuXLdQ7Aq_kyt_cH9Jp2wD16LFmks5sPe2dgaJpZM4OcnlU .

-- Alejandro Inestal García

ainestal commented 7 years ago

The bitstamp_private_tests pass for me. This PR LGTM ;)

ainestal commented 7 years ago

This failing tests for the last commit in Travis CI looks like a network problem from Travis to Bitstamp. I can't reproduce it.

But we should handle that error better.

hugues31 commented 7 years ago

@ainestal Yeah I saw that too but think the same. Thanks for your support. I merge