search

hugues31 / coinnect

Coinnect is a Rust library aiming to provide a complete access to main crypto currencies exchanges via REST API.
MIT License
148 stars 43 forks source link

Next exchange to include? #54

Open ainestal opened 6 years ago

ainestal commented 6 years ago

With the idea in mind of gathering feedback from our users, I would like to propose to the community to ask for inclusions of new exchanges in the library. Something as simple as:

What exchange/s would you like to include in Coinnect and why ?

What do you think @hugues31 ?

hugues31 commented 6 years ago

Yep that's a great idea :) is there a way to create a poll in github or should we use an external services ?

ainestal commented 6 years ago

I don't think there is a poll system in github, external services have to be used. We can begin just with leaving this Issue here. We can link it in the README. The "why" is also very interesting and here we have the space to collect them while we would lose it if we use a simple poll.

not-inept commented 6 years ago

It might also be simple to have a link to this issue and have folks use the 👍 emojii reaction to comments to indicate their votes.

I think it'd be good to see gdax integrated.

hugues31 commented 6 years ago

I added a link in the readme. You can use this discussion to vote for an exchange :)

inv2004 commented 6 years ago

bitmex ?

crackcomm commented 6 years ago

China might be something to think about.

EDIT: South Korea - https://www.bithumb.com/

crackcomm commented 6 years ago

By the way, are you interested in real market functionality or just API?

ainestal commented 6 years ago

@not-inept I started implementing Gdax. For now it should be possible to get the ticker and orderbook for all the pairs in the exchange.

@crackcomm what do you mean by real market functionality and just API?

hugues31 commented 6 years ago

Thanks to @ainestal, Gdax is implemented in Coinnect (only ticker and orderbook). We need to provide a more complete access to the API thought.

tbourvon commented 6 years ago

I'm pretty interested in contributing to the GDAX API as well. In fact I implemented a PoC with the ticker request yesterday as well, before seeing the comments here. Is there a way we could coordinate our efforts here?

hugues31 commented 6 years ago

@tbourvon Hello! You could take a look at the code submitted by the GDAX PR (#58) and see what you can improve :) It should be straightforward to implement the remaining endpoints now

crackcomm commented 6 years ago

Markets

Here is my list with some related links, more or less in priority order dictated mostly by liquidity and quantity of currencies traded.

Poloniex

Bittrex

Cryptopia

Binance

HitBTC

Huobi

Bitfinex

Kucoin

Yobit

Okex

BitMex

theashguy commented 6 years ago

Cryptopia, Kucoin, BTCMarkets for the Crypto-Rustaceans down under.

The first two because they're great exchanges with a wealth of Alts on there giving some interesting trade ops to play with in code, the third because they're they best available on-ramp for Aussie dollars to Crypto.

I hacked together a working BTC Markets connector over christmas so I might look at spending some time over the next period rewriting this following the same patterns as you're using here and then PR it through?

:+1:

hugues31 commented 6 years ago

Hi @theashguy, feel free to send a PR with your implementation. You can copy/paste the implementation from Kraken/Poloniex to serve as a guide. The API will be greatly improved in the next version with Futures support but for now we keep it as is :)

PP-AR-T commented 2 years ago

Kucoin would be nice, I am happy to support on that, I will try to see how far I can get on my own :). PD: Nice Project