huhridge / huh-spicetify-extensions

Collection of my spicetify extensions
218 stars 19 forks source link

listPlaylistsWithSong.js not working here #3

Closed luckybuzz closed 2 years ago

luckybuzz commented 2 years ago

hi there huhridge,

when i right-click songs, i see the option to "list playlists with this song" in the context menu, but clicking that does nothing. i've tried for numerous songs, and tried right-clicking from within a playlist, an album, search results and my queue.

i'm really excited to use this feature, so i'll do anything i can to help you fix/test! dropping a bunch of details below but let me know if i can provide any others :)

Spotify version 1.1.77.643 Spicetify version 2.8.4 extensions activated: tweetMusic.js|playNext.js|genre.js|songstats.js|fullAlbumDate.js|fullAppDisplayMod.js|listPlaylistsWithSong.js custom apps activated: new-releases|lyrics-plus|taste-analyser

huhridge commented 2 years ago

have you updated it? there was a commit 12 days ago, that solved something like this. Try updating if you haven't, if it doesn't work then, send me screenshot of the console in dev-tools Enable dev tools by running, spicetify enable-devtool, and open console

luckybuzz commented 2 years ago

thanks for your reply. yes, using the most recent version of the extension.

my console shows identical errors to the previous reported Issue, just with different line numbers in listPlaylistWithSong.js

image

huhridge commented 2 years ago

can you run this in console and paste the contents in a pastebin and send it here:

userContents = await Spicetify.Platform.RootlistAPI.getContents()
copy(userContents)

btw, do you have any playlists without any image? because I think that is the issue again.

luckybuzz commented 2 years ago

hello again! i believe all the playlists i own or follow have an image. even the ones without a custom image usually generate an image from the first 4 tracks' album art.

i have the console data you requested, however pastebin rejected it as it detected some potentially offensive content (???), so i am sending a zerobin link instead: https://zerobin.net/?c1ac378672180757#NItRYQa6Knm8SY3jsBDJiGGZFdBcT3nQ/xc87o3DcxU=

hope this helps!

huhridge commented 2 years ago

I made a temporary commit for now, which should work! gonna look at this tomorrow

luckybuzz commented 2 years ago

you're the best!

huhridge commented 2 years ago

Screenshot 2022-01-29 at 10 35 15

found the problem, this playlist has songs but doesn't have an image, which is weird because it definitely does,

Screenshot 2022-01-29 at 10 51 34

luckybuzz commented 2 years ago

wow, good catch! i guess since that playlist is made up of songs no longer on spotify, the cover art must not be registering correctly. i'll throw a .png on there as playlist art. thanks for all your help and detective work!

huhridge commented 2 years ago

I feel like the temp commit may just become permanent, to solve these weird edge cases. It is working with the commit right?

luckybuzz commented 2 years ago

yes indeed, been putting it to good use this evening. :)

huhridge commented 2 years ago

imma close this then, thanks for reporting