huhridge / huh-spicetify-extensions

Collection of my spicetify extensions
221 stars 20 forks source link

[Full app display][No icon] #61

Closed YahiaHatab closed 10 months ago

YahiaHatab commented 1 year ago

Describe the bug The extension has no icon, like its not downloaded.

To Reproduce Steps to reproduce the behavior: Downloaded the extension after the new spotify update, and there is no icon.

Expected behavior The extension icon should show up.

Console Errors To check the console, run spicetify enable-devtools in the terminal, and press Ctrl/Cmd+Shift+i and check the console.

Screenshots image

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

ghost commented 1 year ago

Yes, I confirm that it's definitely happening. For me, the workaround is reinstalling the extension every time I want to use it, which is pretty annoying :)

ghost commented 1 year ago

Strange, now it's suddenly working. Why is there uncertainity in the working of this script?

YahiaHatab commented 1 year ago

Strange, now it's suddenly working. Why is there uncertainity in the working of this script?

It didn't work with me at all, i tried to close spotify and reopen it again and even reinstalling the extension but still. I checked the console, and it says "to load resource: net::ERR_NAME_NOT_RESOLVED".

ghost commented 1 year ago

Just a little update: I found out whenever you spicetify enable-devtools, it magically appears (for me) so I can't basically even see the error. Can you post a screenshot of the console error in here?

ghost commented 1 year ago

I am not able to reproduce the error as you describe it, spicetify enable-devtools basically makes it impossible to debug since the moment I run it, the extension runs fine. Strange innit?

ghost commented 1 year ago

I also believe this has to do something with Spicetify not with the extension. As you described that it happens only after the latest Spotify update, I assume something in the binaries broke Spicetify? Basically for which this extension may not have anything to do with the problem as it is Spicetify based I guess.

ghost commented 1 year ago

Update: I runned Spicetify update and that seems to solve the problem for me, I don't have to Spicetify enable-devtools now. If the issue has been solved, you may kindly close it now.

ghost commented 1 year ago
image
YahiaHatab commented 1 year ago

Tried the "spicetify update" but still same issue, and when i check the the console it shows the same error. image

YahiaHatab commented 1 year ago

I also believe this has to do something with Spicetify not with the extension. As you described that it happens only after the latest Spotify update, I assume something in the binaries broke Spicetify? Basically for which this extension may not have anything to do with the problem as it is Spicetify based I guess.

I am sure of this too, since the extension just got updated recently (21st of june), so it should be compatible with the new spotify version.

YahiaHatab commented 1 year ago

Update: image I think the problem is that spicetify can't fetch the extension, i tried multiple extensions and there was the same problem, they are not working at all. I had to download them manually so they could work.

ghost commented 1 year ago

I think the problem is that spicetify can't fetch the extension

That's correct! Can you check if the specific maifest.json was loaded for the extension?

ghost commented 1 year ago
image

For me, it's loaded correctly. Can you specify the version of Spicetify you're using?

ghost commented 1 year ago
image

Also for me, I can't seem to find the fullAppDisplayMod.js file in the scripts section in frames of application tab. Is spicetify on your end, mistaking fullAppDisplayMod.js to be a core spicetify js file?

YahiaHatab commented 1 year ago

I think the problem is that spicetify can't fetch the extension

That's correct! Can you check if the specific maifest.json was loaded for the extension?

Same as everything. image

YahiaHatab commented 1 year ago

For me, it's loaded correctly. Can you specify the version of Spicetify you're using?

I am using 2.20.1 version by spicetify, which should be the latest version.

YahiaHatab commented 1 year ago

Also for me, I can't seem to find the fullAppDisplayMod.js file in the scripts section in frames of application tab. Is spicetify on your end, mistaking fullAppDisplayMod.js to be a core spicetify js file?

That maybe the problem, as the extension is in the scripts folder unlike you. image

ghost commented 1 year ago

That maybe the problem

I believe it is the problem on your side, I didn't even manage to recreate it.

ghost commented 1 year ago

For me, I can confirm once again that enabling devtools just solves the issue magically.

huhridge commented 10 months ago

weird issue, seemed to be with spicetify itself