huhu / rust-search-extension

🦀 The ultimate search extension for Rust
https://rust.extension.sh
Apache License 2.0
1.23k stars 52 forks source link

[Firefox] Does not work in the similar way like other search extensions. #215

Open fuyu0425 opened 1 year ago

fuyu0425 commented 1 year ago

Hello, thanks in advance for this extension!

However, I find that this extension does not work in the similar way like other search extensions on Firefox.

For example, this is the one for GitHub.

圖片

And we can customize the keywords for it in the browser preference.

圖片

However, for this rust-search extension.

  1. We cannot customize the keywords.
  2. type rs and tab in the address tab bar does not work. rs and space still works. 圖片

It might be due to different manifest keywords between Firefox and Chromium browsers? (I have not created a chrome extension before).

The following is some search extension for Amazon I wrote for Firefox before. Not sure this extension works in similar ways.

{
    "manifest_version": 2,
    "name": "Amazon Smile Search",
    "description": "Add Amazon Smile to your search engine. ",
    "version": "1.0",
    "chrome_settings_overrides": {
        "search_provider": {
            "name": "Amazon Smile",
            "search_url": "https://smile.amazon.com/s?k={searchTerms}",
            "keyword": "@amazon",
            "favicon_url": "https://smile.amazon.com/favicon.ico",
            "is_default": false,
            "encoding": "UTF-8"
        }
    }
}

Firefox version: Firefox Developer Edition (107.0b8)

Folyd commented 1 year ago

Hi, @fuyu0425. Thanks for the feedback.

It might be due to different manifest keywords between Firefox and Chromium browsers?

Yes, the rs + tab not working for Firefox. It has nothing to do with manifest keywords I guess. Just because Firefox doesn't support it.

Also good to know the search_provider settings for Firefox, do you mind filing a PR to add such a feature for Firefox?

fuyu0425 commented 1 year ago

Yes, the rs + tab not working for Firefox. It has nothing to do with manifest keywords I guess. Just because Firefox doesn't support it.

The first GitHub extension is after I type @gh and tab.

Also good to know the search_provider settings for Firefox, do you mind filing a PR to add such a feature for Firefox? Because this extension does not work like simply redirecting to another URL with keywords, I am not sure whether this is possible with search_provider keywords.

Folyd commented 1 year ago

Oh, I got it. A static search URL isn't supported right now. However, after using RSE you can forget the Firefox keyword search engine. 😅