search

hui-z / image_gallery_saver

flutter中用于保存图片到相册的Plugin
MIT License
271 stars 346 forks source link

🔥[Urgent] Support AGP 8 and Fix Compile Issue #295

Open knottx opened 4 months ago

knottx commented 4 months ago
  1. Support AGP 8
  2. Fix Compile Issue #272

For people who are waiting for this you can use this in your pubspec.yaml

dependency_overrides:
  image_gallery_saver:
    git:
      url: https://github.com/knottx/image_gallery_saver.git
      ref: knottx-latest
knottx commented 4 months ago

@hyjfine @woodwen @nicolas-landa @dvaldivia @qiuxiang @kazumi007 @ened @zhuyangyang-lingoace @Allen0505 @harithay @HemlockBane @bingbingbog Please merge and release. 🥹

mrgnhnt96 commented 4 months ago

@knottx Thanks for fixing this issue! I've been scratching my head for the last few hours until I came across this fix.

This PR might be more welcomed if you removed all the changes unrelated to the AGP 8 fix. (namely: lints, code formatting, and launch files). However, I know those other changes will be appreciated, so I suggest throwing them into a different PR.

knottx commented 4 months ago

@knottx Thanks for fixing this issue! I've been scratching my head for the last few hours until I came across this fix.

This PR might be more welcomed if you removed all the changes unrelated to the AGP 8 fix. (namely: lints, code formatting, and launch files). However, I know those other changes will be appreciated, so I suggest throwing them into a different PR.

@mrgnhnt96 sure! done.

famasf1 commented 3 months ago

The owner of the repository haven't committed or merge any single PR since June last year. I think we are going to need an alternative fork soon.

natsuk4ze commented 1 month ago

I am running an alternative package. I would be happy to help you.

YarosMallorca commented 3 weeks ago

Please merge this ASAP.

DmitryGaimaldinov commented 3 weeks ago

@knottx, please, add support for flutter 3.24.0 in your repo. Right now building apk with your fork throws

Execution failed for task ':image_gallery_saver:verifyReleaseResources'.
> A failure occurred while executing com.android.build.gradle.tasks.VerifyLibraryResourcesTask$Action
   > Android resource linking failed
     ERROR: 
     /build/image_gallery_saver/intermediates/merged_res/release/values/values.xml:194: AAPT: error: resource android:attr/lStar not found.

This happens due to old compile sdk in android/build.gradle file. While experimenting I found out that compile sdk of a package has to be >=31 to successfully build apk with flutter 3.24.0. But it's better to set 34 right away.

Similar issue happens, for example, in one signal package: https://github.com/OneSignal/OneSignal-Flutter-SDK/issues/930

Sure, I can fork your repo but it'll be helpful for others who also want to use sdk 3.24.0

knottx commented 3 weeks ago

@knottx, please, add support for flutter 3.24.0 in your repo. Right now building apk with your fork throws

Execution failed for task ':image_gallery_saver:verifyReleaseResources'.
> A failure occurred while executing com.android.build.gradle.tasks.VerifyLibraryResourcesTask$Action
   > Android resource linking failed
     ERROR: 
     /build/image_gallery_saver/intermediates/merged_res/release/values/values.xml:194: AAPT: error: resource android:attr/lStar not found.

This happens due to old compile sdk in android/build.gradle file. While experimenting I found out that compile sdk of a package has to be >=31 to successfully build apk with flutter 3.24.0. But it's better to set 34 right away.

Similar issue happens, for example, in one signal package: OneSignal/OneSignal-Flutter-SDK#930

Sure, I can fork your repo but it'll be helpful for others who also want to use sdk 3.24.0

Updated

johnwiese-ms commented 2 weeks ago

Is this ever going to get merged?