search

huilaaja / RedirectManager

Simple and portable redirect manager for Episerver websites
14 stars 5 forks source link

Fixing some missing references and typos #2

Closed tomaszmadeyski closed 7 years ago

tomaszmadeyski commented 7 years ago

Fixing couple of issues:

  1. There's additional } in StringExtensions
  2. System.Net is missing in HtmlErrorController (without that HttpStatusCode is an unknown class
  3. WebProject.Utils is missing in RedirectManager.cshtml. You need to import that in order to use ParseIntOrDefault method
huilaaja commented 7 years ago

Hey, that's excellent. Great and finally I have some proofs that some one else is also using that tool :)

By the way, couple of people have requested some improvements. Do you have some ideas what to improve or some new feature requests? Current requests are mainly improvements for access rights and now with multisite-support to separate the rules for each site/host.

P.s. I just merge your changes into repo and I'll happily do so in the future also :)

-- Mikko Huilaja

--

Mikko Huilaja mikko.huilaja@huilaaja.net +358 503293279

On Mon, Oct 2, 2017 at 4:45 PM, tomaszmadeyski notifications@github.com wrote:

Fixing couple of issues:

  1. There's additional } in StringExtensions
  2. System.Net is missing in HtmlErrorController (without that HttpStatusCode https://github.com/huilaaja/RedirectManager/blob/master/WebProject/Controllers/Misc/HttpErrorPageController.cs#L28 is an unknown class
  3. WebProject.Utils is missing in RedirectManager.cshtml. You need to import that in order to use ParseIntOrDefault https://github.com/huilaaja/RedirectManager/blob/master/WebProject/Views/Admin/RedirectManager.cshtml#L232 method

You can view, comment on, or merge this pull request online at:

https://github.com/huilaaja/RedirectManager/pull/2 Commit Summary

  • Fixing some missing references and typos

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/huilaaja/RedirectManager/pull/2, or mute the thread https://github.com/notifications/unsubscribe-auth/ACNc5nhOiBwq7rbYrm4p3oP4ifLHGUtxks5soOjtgaJpZM4PqqVi .

tomaszmadeyski commented 7 years ago

Hi @huilaaja

I've been trying your tool as well as BVNetwork. It's great that you allow to redirect to contentId and not only to url (string) which is crucial IMO.

What I'm missing is an option to choose an item from content tree, not passing by contentId as integer. I know that SEO Manager can do that but this is commercial extension and it's pretty expensive...

huilaaja commented 7 years ago

Yes, thats definedly needed improvement. I haven't seen simple solutions to implement the Episerver's tree structure since Web Forms and I'm not going back to that :)