search

huiserwang / ContrastMask

Official code for "ContrastMask: Contrastive Learning to Segment Every Thing" (CVPR2022)
https://arxiv.org/abs/2203.09775
30 stars 3 forks source link

”# here we ONLY compute mask loss on novel instances“ in roi_head.py line 158 is right？ #5

Closed niecongchong closed 1 year ago

niecongchong commented 1 year ago

Is the base here wrongly written as novel? If it is novel, how did the mask target of the novel come from?

huiserwang commented 1 year ago

Yes, it should be 'base' rather than 'novel'. You can refer to Line 179 and Line 213 for details. We can know that the final mask loss is calculated on the base objects since the valid_mask is True only when the class of an object is base.

Thank you for pointing out this mistake.