huitema / dnsoquic

DNS over QUIC
10 stars 7 forks source link

Genart review for IESG #148

Closed huitema closed 2 years ago

huitema commented 2 years ago

Reviewer: Stewart Bryant Review result: Ready

I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments.

For more information, please see the FAQ at

https://trac.ietf.org/trac/gen/wiki/GenArtfaq.

Document: draft-ietf-dprive-dnsoquic-08 Reviewer: Stewart Bryant Review Date: 2022-01-20 IETF LC End Date: 2022-01-25 IESG Telechat date: Not scheduled for a telechat

Summary: A well written document ready for publication. It has couple of very tiny nits that could usefully be addressed.

Major issues: None

Minor issues: None

Nits/editorial comments: ALPN is not well known and should be expanded on first use. It would be useful to note that “doq” is a string. This is clarified below, but it is proposed that that text be removed.

huitema commented 2 years ago

These comments are addressed in PR #163 -- but there is no need to specify that "doq" is a string, as it is an ALPN token.