search

huiwang / codingame-scala-kit

Create Better CG Bot in Scala
23 stars 15 forks source link

Bundler generates package object to handle several classes with same name #32

Closed tyrcho closed 7 years ago

tyrcho commented 7 years ago

18

tyrcho commented 7 years ago

seems to be working fine, but we need some more tests before merging it.

huiwang commented 7 years ago

@tyrcho the failure in the CI should be fixed with #33

tyrcho commented 7 years ago

@huiwang OK, I'll merge the #33 in this PR then.

I still need to implement the case of package with several components (com.truelaurel...), the output code does not compile.

tyrcho commented 7 years ago

@huiwang I've tested this and it LGTM (looks good to me), including a full test on real code. Would you please have a look before merging it ?

tyrcho commented 7 years ago

@huiwang good idea ! was not straightforward because scala won't allow you to import 2 classes of the same name in the same scope, and we don't support things like import aliases. But I'm pretty happy with this new test case.