search

hukkin / hdwallets

Implementation of BIP32 – Hierarchical Deterministic Wallets
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Requires ecdsa < 0.15 #5

Open scottyeager opened 3 years ago

scottyeager commented 3 years ago

Running hdwallets.BIP32.from_seed(), I see AttributeError: 'mpz' object has no attribute 'to_bytes'.

Fixed by downgrading to python-ecdsa 0.14.1, as suggested here: https://github.com/spesmilo/electrum/issues/6068

hukkin commented 3 years ago

Hey, thanks for the issue!

Would you be able to come up with a test case and exact dependency versions to reproduce this? The tests in CI do execute hdwallets.BIP32.from_seed(seed) using ecdsa==0.17.0 and seem to be passing. I also tried installing ecdsa==0.15.0 locally and the tests did pass with that as well.

jamarisi commented 2 years ago

Hi, I bumped with this issue today by installing gmpy2.

MementoRC commented 1 year ago

This should fix it in _utils.py:

-CURVE_ORDER = CURVE_GEN.order()
+CURVE_ORDER = int(CURVE_GEN.order())
MementoRC commented 1 year ago

@hukkin , master has a 0.1.2 tag, but it does not match the pypi 0.1.2 package, in particular, when trying to create a conda recipe, it fails. master has the fix needed in _bip32.py. FYI, the attempt at the conda recipe is at: https://github.com/conda-forge/staged-recipes/pull/23790