search

hulop / HLPDialog

MIT License
0 stars 6 forks source link

Create Arabic Localizable.strings #3

Closed Mahabmn closed 2 years ago

daisukes commented 2 years ago

Hi @Mahabmn, thank you for your contribution!

Before merging I need to ask you two things.

  1. Could you please read the How can I contribute? section and follow the instructions. It is related to copyright.
  2. Could you tell me a little bit about your project background?
Mahabmn commented 2 years ago

Hi @Mahabmn, thank you for your contribution!

Before merging I need to ask you two things.

  1. Could you please read the How can I contribute? section and follow the instructions. It is related to copyright.
  2. Could you tell me a little bit about your project background?

Hello , thank you for providing me the link I will check it and follow the steps , about my project , I have a graduation to create an arabic version of NavCog.

Mahabmn commented 2 years ago

hello I have update the pull request and send the CONTRIBUTOR LICENSE AGREEMENT (CLA) to the identified email in the document .

daisukes commented 2 years ago

Thank you for updating PR #4 and your project description. I will close this PR. By the way, which commit of NavCogIOSv3 are you using? Recently (about one month ago), I've updated NavCogIOSv3 and it refers swift-package branch of this repository.

Mahabmn commented 2 years ago

thank you

Regarding NavCogIOS3 , thank you for updating me because I was using an old version .

daisukes commented 2 years ago

Are you using XCode12?

Mahabmn commented 2 years ago

I am using XCode13