Incorrect exit code is returned when npm test fails

hulu / roca

A command-line tool for running brightscript tests

Apache License 2.0

25 stars 19 forks source link

Incorrect exit code is returned when npm test fails #94

Closed alimnios72 closed 3 years ago

alimnios72 commented 3 years ago

Running npm test is always returning a success exit code (0) even when unit tests failed, some wrong syntax is found or --forbid-focused is called with focused test cases. This bug will break CI/CD system that rely on exit codes from the command because it will think that there are no failures after running the command

alimnios72 commented 3 years ago

Note: you can verify above by making sure a test fails and then running echo $? and seeing that the last exit code was 0