humaan / Modaal

An accessible dialog window library for all humans.
http://humaan.com/modaal/
MIT License
2.72k stars 183 forks source link

Some areas outside video modal don't trigger modal close on click #111

Open geeseyj opened 6 years ago

geeseyj commented 6 years ago

On video modals, at various screen sizes the div.modaal-video-wrap is wider than the actual video. Screenshot below:

image

Clicks on that extra space won't close the modal since the event listener is listening for a click on div.modaal-inner-wrapper

This makes it unresponsive when it should close the modal like other outside clicks.

I've observed this on the demo site in various browsers.

I'll send a pull request after opening this ticket. 🙂