search

humaan / Modaal

An accessible dialog window library for all humans.
http://humaan.com/modaal/
MIT License
2.72k stars 183 forks source link

Make .modaal-close:hover color SASS variable #55

Closed lewismcarey closed 8 years ago

lewismcarey commented 8 years ago

The SASS variables are really handy. I think the close hover color is the color I find myself changing the most (yet it isn't set as a SASS variable).

danhumaan commented 8 years ago

hi @lewismcarey, thanks for your patience in allowing us time to address this. I've worked in a change as requested and implemented in your pull request, however I won't be accepting or applying your pull request due to a number of other differences that are unrelated and not wanted such as the change to browser prefixes and vendors.

We will roll out the change completed in the coming milestone, so please watch for that implementation then.

lewismcarey commented 8 years ago

@danhumaan Thanks for the update and associated implementation.