search

humaan / Modaal

An accessible dialog window library for all humans.
http://humaan.com/modaal/
MIT License
2.72k stars 183 forks source link

Using Instagram - Uncaught TypeError: Cannot read property 'Embeds' of undefined #72

Closed paulburgess closed 6 years ago

paulburgess commented 8 years ago

Using the modaal for showing instagram popups, everything still works but this error appears in the console: Uncaught TypeError: Cannot read property 'Embeds' of undefined

Refers to line 151: window.instgrm.Embeds.process())

I think :-)

danhumaan commented 8 years ago

Good pickup, thanks for flagging this @paulburgess - is this stopping your instance from working? For me it's still working, but I can see the error. Worth investigating, but just trying to determine how much of a prioty this issue is, ie: it's stopping things working vs, it works but throws and error.

paulburgess commented 8 years ago

It all seems to works fine. I tried an older version as well and the issue was there too. But you know how it is... that red text staring at you from Developer Tools.

danhumaan commented 8 years ago

Ok no worries, thanks @paulburgess - we'll investigate and see what we can do.

danhumaan commented 8 years ago

hey @paulburgess, thanks again for raising the issue. I've worked in a fix and pushed it through to our develop branch. Will roll out a new milestone release soon that will have this included.

Leaving this open until we roll out the release, will close it then. Thanks