search

humaan / Modaal

An accessible dialog window library for all humans.
http://humaan.com/modaal/
MIT License
2.72k stars 183 forks source link

Modaal with screen readers #87

Closed alstoiche closed 6 years ago

alstoiche commented 7 years ago

Hey guys, great work here. Just one little thing I've come across though. There's a little problem with how some screen readers look at markup with role="dialog", so markup inside it is ignored. I think it works in some readers, but not all.

https://github.com/nvaccess/nvda/issues/4493

We've been playing around with attaching a role="document" to one of the divs inside the dialog to get the SR to treat the div as containing document content. It looks like you could drop it on the "modaal-content-container" div. Just a thought!

Cheers,

Al

danhumaan commented 6 years ago

hi @alstoiche, thanks for sharing this finding with us, and thank you for your patience in us getting to this issue. We've implemented the role dialog and tested again across chrome, ie and firefox with the latest NVDA. Please keep and eye on the next release for this inclusion.