search

humaan / Modaal

An accessible dialog window library for all humans.
http://humaan.com/modaal/
MIT License
2.72k stars 183 forks source link

Hard-coded “(Press escape to close)” in dialog title aria-label (l10n) #92

Closed mirka closed 6 years ago

mirka commented 7 years ago

There is a “(Press escape to close)” appended to the dialog title aria-label that can't be overridden through the accessible_title or the localization options added in https://github.com/humaan/Modaal/issues/41. https://github.com/humaan/Modaal/blob/master/source/js/modaal.js#L358

danhumaan commented 7 years ago

Thanks @mirka good pickup.

danhumaan commented 7 years ago

This has been been addressed. The relevant hard coded text has been replaced with the close_aria_label option value so users who wish to overwrite it along with the close button label, can do so.

This will be rolled out in the next milestone release