human-internet / humanid-reactnative-sdk

humanID SDK for React Native
GNU General Public License v3.0
0 stars 6 forks source link

[TN-290] [URGENT] RN Login not opening success URL after usual login flow #19

Open bastian-purrer opened 3 months ago

bastian-purrer commented 3 months ago

See video, recorded in Helio app on 22 July 2024.

THis is a recurring user, not a new user for the Helio app.

Current behavior: After logging in, the user is seeing the "Success" notification, but is not logged in. Image

Expected behavior: Log the user in

https://github.com/user-attachments/assets/45a9f37c-e7f4-4f18-b7ca-caae96be9ce1

Current State

The issue stems from the fact that the source does not persist when calling the weblogin or the wrong source is set in the web login url. The source determines which urls to call as the redirect url.

How does the app know if it is mobile or web?

the source is determined from s parameter in the web login url.

Proposed Plan

There are 3 places to check: the React Native SDK, the Core and the Weblogin

Image

bastian-purrer commented 3 months ago

@falhar

bastian-purrer commented 3 months ago

7/29 - status unclear, potentially overlapping with TN287, see whatsapp for followup

bastian-purrer commented 3 months ago

Aug 12: Short-term: Client is testing deepllink solution If it works, we need to define a bigger project to separate mobile links (???)