search

human-internet / humanid-weblogin

GNU General Public License v3.0
7 stars 1 forks source link

TN237 - resend SMS bug #30

Open bastian-purrer opened 5 months ago

ccrawford4 commented 4 months ago

Resolved - PR created

ccrawford4 commented 4 months ago

Changes were made to prevent users from resending the code until AFTER 60 seconds has passed with a timer on the front-end. All changes were since made and moved into the develop branch. The changes to web-login need to be reflected on the amazon ec2 instance

bastian-purrer commented 4 months ago

@ccrawford4 review: just shows a white screen for me now on web image

bastian-purrer commented 4 months ago

@ccrawford4 does this bug affect web and the SDKs, or only web? does it need testing across platforms? (particularly worried about the RN sdk).

tech-lead-humanID commented 4 months ago

@bastian-purrer for the first comment, append /demo to the end of the url. As for the count-down from my understanding this fix should only impact the SDK's that rely on the web-login. So any Native apps that are using the react-native SDK will not be impacted by these changes but I can confirm with Kofi to make sure

ccrawford4 commented 3 months ago

@bastian-purrer please have a look: https://staging.web-login.human-id.org/demo/

The SMS countdown can now be viewed

bastian-purrer commented 2 months ago

@ccrawford4 approved for production

tech-lead-humanID commented 1 week ago

@ccrawford4 has this been completed?