search

human-internet / humanid-weblogin

GNU General Public License v3.0
7 stars 1 forks source link

[TN-298] App crashes if phone number too short//check missing #53

Open bastian-purrer opened 3 weeks ago

bastian-purrer commented 3 weeks ago

Tested in Helio app (Production, not the test) React Native implementation.

https://github.com/user-attachments/assets/09887bc0-80d0-459c-9c07-d79f06e82260

What: • app crashes when user tries to advance with only 8-digit phone number. • if work with 10-digit number. Expected: • Cannot proceed if number is <7 digits (but also no crash). Button is grey • If ≥7 digits, then proceed. • never crash

My guess: I think in the past, there was a check for the button, so the crash scenario cannot happen. I think we should not only make the button inactive, but also solve the crash issue, just in case

bastian-purrer commented 3 weeks ago

cc @Lunasocute Maybe @oottoohh wants to take this?

oottoohh commented 3 weeks ago

@bastian-purrer RN SDK using webview so this is can resolved from web login side. i try to take RN SDK issue first cause i have been long time no play around with python web.

bastian-purrer commented 1 week ago

@kofimokome maybe you could take this? not sure who