Prepare core executions

human-solutions / xcframework

Cargo plugin for building XCFrameworks

MIT License

6 stars 4 forks source link

Prepare core executions #10

Closed Binlogo closed 3 months ago

Binlogo commented 4 months ago

Fixes #11

General core logic part is initially ready, include warp library to framework to support dynamic link for more platforms.

[x] Tweak all exist cmds to use core functions.
- [x] Encapsulate dynamic library into framework to fix #11
  - ref: Technical Note TN2435: Embedding Frameworks In An App
  - [x] Use tuist to create ios example for test for dynamic link

More roadmap: #7

Binlogo commented 4 months ago

Please review, @akesson. Thank you. If you have any suggestions, please point them out, and I will address them.

akesson commented 3 months ago

Oh, and sorry for not reviewing it before. I have a lot of things on my plate... I'll try to be faster.

Binlogo commented 3 months ago

@akesson Thanks for your comments, I've updated them. Please review again. 🙏

Binlogo commented 3 months ago

There's still things in the tuist readme that doesn't work, but that's ok. As you pointed out, this is with focus on the core changes.

Yes, I've checked the README, and it worked locally on my machine. However, since this is my first time using Tuist, I might have overlooked some requirements.

This is a starting point to enhance support for more platforms seamlessly. We will continue to fix and improve these aspects, including tests that are not working on CI yet🤦.

Just one code comment I did that I'm not sure if you missed, except for that one it's good to go.

I have responded to that comment. Please review my response to see if I misunderstood anything. If so, I will continue to iterate.

akesson commented 3 months ago

Sorry for that confusion, regarding the comment without reply, that was in reality already fixed. I was too tired to work yesterday...

A big thank you for this contribution and already looking forwards to the next one 😄