human-solutions / xcframework

Cargo plugin for building XCFrameworks
MIT License
6 stars 4 forks source link

Feature request: Mac Catalyst support #3

Closed imWildCat closed 4 months ago

imWildCat commented 1 year ago

A low-priority request: The nightly compiler now supports Mac Catalyst (example).

If needed, I could start a PR for it.

akesson commented 1 year ago

Sure, that would be great!

imWildCat commented 1 year ago

Mac Catalyst would require nightly toolchain. Because they are at Tier 3 (https://doc.rust-lang.org/nightly/rustc/platform-support.html#tier-3).

I found currently, the design of xcframework would require the user to specify whether it is nightly, like cargo +nightly xcframework. But in most use cases, we would build iOS and macOS using stable, and Catalyst using nightly.

What do you think of the design of Catalyst support?

(no rush)

akesson commented 1 year ago

Will you use the Catalyst support? If not, then I suggest waiting until someone needs it.

You should probably use something like rustversion to conditionally build the support for Catalyst only on nightly. However, from my experience, it ends up being much harder to maintain. Would probably be best to add GitHub CI for automatically testing both stable and nightly compiles.

imWildCat commented 1 year ago

ok! I actually have some custom script which have similar functionality with xcframework.

I think we can hold on the implementation of Catalyst.

Would probably be best to add GitHub CI for automatically testing both stable and nightly compiles.

That's also what I expect. Maybe I can raise a small PR to set up GH Actions.

akesson commented 1 year ago

Yes please do. And include the checks: cargo fmt --check and cargo clippy -- -Dwarnings. 😄

akesson commented 4 months ago

@imWildCat I'll close this ticket unless you are still interested in creating a PR for it.

imWildCat commented 4 months ago

ok sure