Allow variables overriding from the command line

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Try gyp -f make -DOS=freebsd
2. See that gyp file will be parsed with OS=linux
3. Cry to sleep

I'm using gyp on FreeBSD 7.2-RELEASE.

The attached patch uses the generator default variables first then the
command line variables.

Original issue reported on code.google.com by florent....@gmail.com on 5 Jun 2009 at 9:49

Attachments:

• gyp-cmdline.diff

[GoogleCodeExporter]

You'll need to update the patch since the code changed too much (e.g. was moved 
into 
Load()).

Original comment by maruel@chromium.org on 9 Jul 2009 at 7:01

[GoogleCodeExporter]

Here's an updated patch.

Original comment by florent....@gmail.com on 9 Jul 2009 at 7:51

Attachments:

• gyp-cmdline-v2.diff

[GoogleCodeExporter]

Updated patch for submitted for review.

http://codereview.appspot.com/96041

Original comment by florent....@gmail.com on 15 Jul 2009 at 2:18

[GoogleCodeExporter]

I'll look at adding this.  Can't see that it should cause any problems.

Original comment by sgk@chromium.org on 6 Aug 2009 at 6:10

• Changed state: Accepted

[GoogleCodeExporter]

Florent--  I have a CL ready to submit with your patch (including a 
modification to 
the variables test case to cover this behavior).  Before I can do so, though, 
you need 
to sign and submit either an Individual Contributor License Agreement:

http://code.google.com/legal/individual-cla-v1.0.html

Or a corporate agreement if this patch is on behalf of a company:

http://code.google.com/legal/corporate-cla-v1.0.html

It can be done on-line and should only take a minute or so.

I'm adding an AUTHORS file to gyp and will add your name there as part of this 
CL 
once the agreement is signed.

Thanks!

Original comment by sgk@chromium.org on 22 Oct 2009 at 5:27

[GoogleCodeExporter]

r797

Original comment by mmoss@chromium.org on 9 Mar 2010 at 8:49

• Changed state: Fixed