Mennaruuk
commented
2 years ago Hey @AccentuSoft ! Thank you ever so much for this. I truly appreciate it. You guys are really awesome.
In fact, if you are interested in taking over this project, or know somebody who wants to, I'm more than happy to transfer it over. I believe there is so much potential to be tapped with somebody who knows a lot more than someone like me who is struggling with the basics. Like I had no idea about things like async, Puppeteer, or Playwright, and don't think I'll get much further with them. I'm totally okay with whatever's on your mind, I'll try my best to continue developing with the knowledge that I have, but I'm extremely novice at Python (this was my first project), and a more knowledgeable leadership can take this project to new heights, and I want to see it help as much as possible.
Please make a PR, that way it'll be in your name!!
AccentuSoft
Hello,
We recently came across your project, and thought we could contribute by re-writing some parts of the code. An effort was made to keep the logic and structure of the code the same.
By our metrics, we have achieved a speed-up of around 20-30% for accounts with over 1000 tweets. We don't have any actual tests written for the script however, so we have attached it here for review.
A substantial change was moving from Selenium to Playwright. Users need to run 'playwright install' to install the playwright browsers before running the script.
Another smaller, but notable change is that due to the nature of the as_completed function, it is not possible to show any indicator of progress during the gathering of statuses, and the order in which the tweets are returned is scrambled due to the script processing website information based on what web request finishes first.
If the style & format of the re-write is acceptable, and the changes proposed are not considered to be critical, we will proceed with creating a pull request.
twayback2.txt