search

humangeo / leaflet-dvf

Leaflet Data Visualization Framework
MIT License
689 stars 153 forks source link

0.8dev #44

Closed pagameba closed 10 years ago

pagameba commented 10 years ago

This fixes two issues. First, the centering of images in RegularPolygonMarker was broken because of an incorrect text anchor point. Second, hovering over chart markers caused them to go black due to missing style references. This is fixed by correctly removing and re-adding patterns and circles to defs in _updateStyle

sfairgrieve commented 10 years ago

Thanks again @pagameba!

pagameba commented 10 years ago

no problem! There is still a bunch of stuff in leaflet.dvf.markers.js that I have no clue what to do with.

sfairgrieve commented 10 years ago

Yeah, definitely. Some of that has to do with applying styles/text to lines and polygons vs. point features, but I need to do some more research on how that fits in with 0.8. I think there might also be some issues with DataLayer instances as well. There are definitely a lot of things that need to change. What still doesn't work that you need? SVG markers?

pagameba commented 10 years ago

Not sure if there is anything else that I need right now, MapMarkers might do the trick. I'm just trying to integrate it into my project to see what happens.

I would like to be able to minimize the size of the code I'm including, there is a bunch of stuff built into the markers dist file that I definitely won't need. Would you be open to splitting up the src files into more distinct components? And possibly replacing your build script with grunt?

sfairgrieve commented 10 years ago

Ok, great. I'll let you know when I get the SVG marker stuff working. I'm moving a little slowly this week due to other commitments. I'm absolutely open to splitting up src files and using Grunt. I've been meaning to do both, and this seems like a good time to do that.

On Tue, Sep 9, 2014 at 1:00 PM, Paul Spencer notifications@github.com wrote:

Not sure if there is anything else that I need right now, MapMarkers might do the trick. I'm just trying to integrate it into my project to see what happens.

I would like to be able to minimize the size of the code I'm including, there is a bunch of stuff built into the markers dist file that I definitely won't need. Would you be open to splitting up the src files into more distinct components? And possibly replacing your build script with grunt?

— Reply to this email directly or view it on GitHub https://github.com/humangeo/leaflet-dvf/pull/44#issuecomment-55001875.

pagameba commented 10 years ago

ok, once I've tested and made sure I can do what I need, I'll work up a PR for splitting up the src files and building using grunt.