humangeo / leaflet-dvf

Leaflet Data Visualization Framework
MIT License
689 stars 153 forks source link

IE8 minor bugs #6

Open cputer opened 10 years ago

cputer commented 10 years ago

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.2; Trident/4.0; Data Center; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.04506.648; .NET CLR 3.5.21022; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729) Timestamp: Wed, 20 Nov 2013 19:41:40 UTC

Message: 'L.Util' is null or not an object Line: 5 Char: 681 Code: 0 URI: https://smartdata.columbiatechnologies.com/dist/leaflet-dvf.min.js

Message: 'L.Class' is null or not an object Line: 9 Char: 13 Code: 0 URI: https://smartdata.columbiatechnologies.com/dist/leaflet.label.js

Message: Object expected Line: 25 Char: 5 Code: 0 URI: https://smartdata.columbiatechnologies.com/p/exp/markham/project72/mississauga/maps.js

cputer commented 10 years ago

seems to be only an IE8 issue and earlier

sfairgrieve commented 10 years ago

Can you do me a favor and grab the latest version of leaflet-dvf.min.js? It looks like your version is older than the latest version in the dist directory. Just wondering if this might make a difference, since several semi-recent changes have been made to support IE. Also, do you mind navigating to one of the examples in the README to see if that fails as well?

cputer commented 10 years ago

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.2; Trident/4.0; Data Center; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.04506.648; .NET CLR 3.5.21022; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729) Timestamp: Thu, 21 Nov 2013 02:37:14 UTC

Message: Expected identifier, string or number Line: 116 Char: 4 Code: 0 URI: http://humangeo.github.io/leaflet-dvf/src/leaflet.dvf.markers.js

Message: 'Core' is undefined Line: 1787 Char: 13 Code: 0 URI: http://humangeo.github.io/leaflet-dvf/dist/leaflet-dvf.js

Different and various errors in examples.. too

sfairgrieve commented 10 years ago

Sorry to make you jump through hoops, but I think we're getting somewhere. I forgot that the examples haven't been updated to work with older browsers, so suggesting you try those was a mistake on my part. Can you add the Core Framework script to your application: https://code.google.com/p/core-framework/wiki/svg? The basic problem here is that older versions of IE (6-8) don't support SVG, so using the Core Framework provides a quick workaround for converting SVG paths into VML paths that should work in IE.

On Wed, Nov 20, 2013 at 9:40 PM, cputer notifications@github.com wrote:

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.2; Trident/4.0; Data Center; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.04506.648; .NET CLR 3.5.21022; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729) Timestamp: Thu, 21 Nov 2013 02:37:14 UTC

Message: Expected identifier, string or number Line: 116 Char: 4 Code: 0 URI: http://humangeo.github.io/leaflet-dvf/src/leaflet.dvf.markers.js

Message: 'Core' is undefined Line: 1787 Char: 13 Code: 0 URI: http://humangeo.github.io/leaflet-dvf/dist/leaflet-dvf.js

Different and various errors in examples.. too

— Reply to this email directly or view it on GitHubhttps://github.com/humangeo/leaflet-dvf/issues/6#issuecomment-28953550 .

cputer commented 10 years ago

have u ever tried: http://code.google.com/p/css3-mediaqueries-js/ in place of jquery? but its only probably relevant to css

sfairgrieve commented 10 years ago

No, I haven't, but it looks interesting. I'll have to check that out.

Any luck with IE 8 and below? Did adding the latest leaflet-dvf.min.js file and the Core framework to your app make any difference?