search

humangeo / leaflet-dvf

Leaflet Data Visualization Framework
MIT License
689 stars 152 forks source link

Using MarkerCluster plugin with DataLayer #67

Open FarhodKurbonov opened 9 years ago

FarhodKurbonov commented 9 years ago

As I understand, DataLayer extend leaflets LayerGroup and in cicle via method named locationToLayer added every layer in LayerGroup. Is there opportunity to add layer not to layerGroup but to MarkerClasterGroup. I try it but with no result. I would be grateful if you take me direction as it possibly to implement claster via DataLayer... Thank for you suggest

sfairgrieve commented 9 years ago

@FarhodKurbonov you should be create the DataLayer and then just add that DataLayer instance to the MarkerClusterGroup as a single layer. Let me know if this doesn't work.

FarhodKurbonov commented 9 years ago

@sfairgrieve. I did as your recommendation in the example of 'earthquakes4' of this repository everything works fine. But unfortunately tooltip functionality was broken (tooltip does not show). Same result with 1.0 branch and leaflet 1.0 beta 1

sfairgrieve commented 9 years ago

Thanks for pointing this out. I'm seeing the same problem and will try to have a fix in soon.

sfairgrieve commented 9 years ago

Still trying to figure this one out. I believe since the tooltip is being added to the DataLayer/LayerGroup that clustering is being performed on, the MarkerCluster plugin is hiding it/not displaying it. I've tried changing the code to add the tooltip directly to the map, but in the MarkerCluster case, it's not calling onAdd for the DataLayer, so _map is never being set.

sfairgrieve commented 9 years ago

Check out the earthquakes4 example in the 1.0dev branch. I updated this example to use the MarkerCluster plugin. Right now, it's a little bit hacky, but it works. I'm still looking at ways to make this better, and I might make another update soon.

sfairgrieve commented 9 years ago

Ok, ignore my comments from a few minutes ago. The latest code in the 1.0dev branch and the earthquakes4 example should be good. I changed some of the tooltip logic so it works better with the MarkerCluster plugin.

FarhodKurbonov commented 9 years ago

Thanks a lot for help. It seems tooltip work properly.