Fix project not initializing correctly when loaded from an URL

humanitiesplusdesign / palladio

An application that brings humanities research methods to data visualization.

BSD 3-Clause "New" or "Revised" License

170 stars 31 forks source link

Fix project not initializing correctly when loaded from an URL #118

Closed jiemakel closed 8 years ago

jiemakel commented 8 years ago

Issue #117 . The problem occurred because loadService.loadJson returns a promise, but onLoad was not chained to that promise. Therefore, onLoad ran before all information it needed was available.

esjewett commented 8 years ago

Nice catch. Thank you - I'll review and merge tonight.

esjewett commented 8 years ago

Actually @jiemakel , I forgot that you have write access to the repo - sorry :-) Feel free to merge this yourself. It looks fine to me but I will test a bit more this evening.