A reviewed dimension should not have the "please review" tooltip

humanitiesplusdesign / palladio

An application that brings humanities research methods to data visualization.

BSD 3-Clause "New" or "Revised" License

170 stars 31 forks source link

A reviewed dimension should not have the "please review" tooltip #124

Closed elizawe closed 8 years ago

elizawe commented 8 years ago

Even when the dot is grey, the tooltip says "please review"

esjewett commented 8 years ago

I'm not able to recreate, unfortunately. This is on the latest version on the website?

elizawe commented 8 years ago

screen shot 2016-01-19 at 3 07 59 pm

esjewett commented 8 years ago

I see. We actually shouldn't be displaying the grey dot at all in this scenario. To reproduce, toggle the special character in the dimension view to mark it as "okayed" and then the grey dot will show up even though it shouldn't.

esjewett commented 8 years ago

Ok, I now recall that I actually don't remember if we are supposed to be showing the grey dot or not in this scenario. I've changed the tooltip text to "Verified" (see commit) and left it visible. This dot is visible only in the situation where the dimension has special characters but they have all been verified.