search

humanitiesplusdesign / palladio

An application that brings humanities research methods to data visualization.
BSD 3-Clause "New" or "Revised" License
170 stars 31 forks source link

Timeline - add option to group by none #137

Closed cncoleman closed 8 years ago

esjewett commented 8 years ago

If you try the latest, there is an "X" next to the group-by selection that allows the user to clear the selection.

screen shot 2016-02-05 at 10 35 59 am

Look ok?

cncoleman commented 8 years ago

Does it not work to just have "none" as an option in the drop-down list?

esjewett commented 8 years ago

It's a dimension selection modal, not a drop-down, so it's not obvious but you are already allowed to actually click the selected dimension again to de-select it. That leaves no dimension selected. Previously this would break the timeline, but now it works as well.

I'd not want to add another "None" option in the modal, as it would look like a dimension. We could add a control to the modal to deselect all dimensions or something like that.