search

humanitiesplusdesign / palladio

An application that brings humanities research methods to data visualization.
BSD 3-Clause "New" or "Revised" License
170 stars 31 forks source link

Timespan Displays Deathdate as same as birthdate if one or the other is missing. #160

Closed cncoleman closed 7 years ago

cncoleman commented 7 years ago

This is a distortion of the data and results in a misrepresentation of the data in the graph. See attached. screen shot 2016-08-16 at 2 05 08 pm

esjewett commented 7 years ago

Possibly 2 separate issues here:

  1. The tooltip display that should (I agree) show which one is missing
  2. The visual display that displays either a vertical line or a single dot, depending on the view being shown.

In the case of 1, I completely agree that we should indicate the missing value in the tooltip. In the case of 2, what are your thoughts on what we should be doing differently here?

cncoleman commented 7 years ago

If we are capturing and processing the data as 1. viable value + 2. missing value, then we would be fine with the graphic. It's not actually the graphic display that is the problem. It's the resulting interaction/data manipulation. I cannot filter to just people whose birthdate falls in a certain range. If those people are missing a death date, the death date becomes equal to the birthdate. As a result, I have to select the range of date in both the birthdate and the deathdate. That is illogical and interferes with filtering on complete birth-death dates.

cncoleman commented 7 years ago

Attached an image showing how filtering on Birth year yields an incorrect result. screen shot 2016-08-16 at 2 50 08 pm

cncoleman commented 7 years ago

I guess we could treat it as a feature instead of a bug. The advantage is that it gives you a way to select those who do not have birthdates. But the interaction is too wrong. It just doesn't make sense.

esjewett commented 7 years ago

Ahhhhh, yup. Thanks, I think that clarifies what I need to do here. Will see what I can do.

esjewett commented 7 years ago

This should be fixed in palladio-timespan-component version 1.1.0. If you pull down the latest master branch of palladio-app, it should be fixed there too (you'll need to do a 'bower update'). It's tagged as palladio-app#1.2.2 and we can push it to the main site once we are ready.

Can you confirm if it works?

cncoleman commented 7 years ago

It works! Thanks

From: Ethan Jewett notifications@github.com Sent: Tuesday, August 16, 2016 4:12 PM To: humanitiesplusdesign/palladio Cc: Catherine Nicole Coleman; Author Subject: Re: [humanitiesplusdesign/palladio] Timespan Displays Deathdate as same as birthdate if one or the other is missing. (#160)

This should be fixed in palladio-timespan-component version 1.1.0. If you pull down the latest master branch of palladio-app, it should be fixed there too (you'll need to do a 'bower update'). It's tagged as palladio-app#1.2.2 and we can push it to the main site once we are ready.

Can you confirm if it works?

You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/humanitiesplusdesign/palladio/issues/160#issuecomment-240267823, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AARlBVbrQEzmDP_CTg7wkIpH7JGByIzbks5qgkPcgaJpZM4Jl3rn.

esjewett commented 7 years ago

Cool. Just as a quick overview, everything excep the tool tips should be the same in "bars" mode. But in the parallel/slope-graph mode it no longer displays lines for things that are missing one of their dates. Instead, I have started showing the endpoint dots in this mode on the axes. So for data points with one one of the dates it just shows a dot on the appropriate axis.  Thanks,Ethan

On Tue, Aug 16, 2016 at 6:19 PM -0500, "Nicole Coleman" notifications@github.com wrote:

It works! Thanks

From: Ethan Jewett notifications@github.com

Sent: Tuesday, August 16, 2016 4:12 PM

To: humanitiesplusdesign/palladio

Cc: Catherine Nicole Coleman; Author

Subject: Re: [humanitiesplusdesign/palladio] Timespan Displays Deathdate as same as birthdate if one or the other is missing. (#160)

This should be fixed in palladio-timespan-component version 1.1.0. If you pull down the latest master branch of palladio-app, it should be fixed there too (you'll need to do a 'bower update'). It's tagged as palladio-app#1.2.2 and we can push it to the main site once we are ready.

Can you confirm if it works?

You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHubhttps://github.com/humanitiesplusdesign/palladio/issues/160#issuecomment-240267823, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AARlBVbrQEzmDP_CTg7wkIpH7JGByIzbks5qgkPcgaJpZM4Jl3rn.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

cncoleman commented 7 years ago

That's a good solution. Nice.

On Tue, Aug 16, 2016 at 5:38 PM -0700, "Ethan Jewett" notifications@github.com<mailto:notifications@github.com> wrote:

Cool. Just as a quick overview, everything excep the tool tips should be the same in "bars" mode. But in the parallel/slope-graph mode it no longer displays lines for things that are missing one of their dates. Instead, I have started showing the endpoint dots in this mode on the axes. So for data points with one one of the dates it just shows a dot on the appropriate axis. Thanks,Ethan

On Tue, Aug 16, 2016 at 6:19 PM -0500, "Nicole Coleman" notifications@github.com wrote:

It works! Thanks

From: Ethan Jewett notifications@github.com

Sent: Tuesday, August 16, 2016 4:12 PM

To: humanitiesplusdesign/palladio

Cc: Catherine Nicole Coleman; Author

Subject: Re: [humanitiesplusdesign/palladio] Timespan Displays Deathdate as same as birthdate if one or the other is missing. (#160)

This should be fixed in palladio-timespan-component version 1.1.0. If you pull down the latest master branch of palladio-app, it should be fixed there too (you'll need to do a 'bower update'). It's tagged as palladio-app#1.2.2 and we can push it to the main site once we are ready.

Can you confirm if it works?

You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHubhttps://github.com/humanitiesplusdesign/palladio/issues/160#issuecomment-240267823, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AARlBVbrQEzmDP_CTg7wkIpH7JGByIzbks5qgkPcgaJpZM4Jl3rn.

You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/humanitiesplusdesign/palladio/issues/160#issuecomment-240281756, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AARlBZ6fl0ID43jw3jL4mKr60yETuus5ks5qglgFgaJpZM4Jl3rn.