humanitiesplusdesign / palladio

An application that brings humanities research methods to data visualization.
BSD 3-Clause "New" or "Revised" License
170 stars 31 forks source link

Palladio Embed discrepancy with set parameters #164

Closed cncoleman closed 7 years ago

cncoleman commented 7 years ago

screen shot 2016-08-25 at 1 23 48 pm

You can see (faintly) behind the code window that the timeline displayed in the embed app has a group applied. It is "gender". And yet in the code, the group for timeline is "null". When viewing this component embedded in an html page, a group again appears in the timeline. It seems to be "Additional Language".

esjewett commented 7 years ago

I hope this is fixed. There was a bug in the palladio-timeline-component (https://github.com/humanitiesplusdesign/palladio-timeline-component/issues/2), the palladio-embed-app was using an old version of the component, and the embed app was generating the wrong embed code in this scenario.