search

humanitiesplusdesign / palladio

An application that brings humanities research methods to data visualization.
BSD 3-Clause "New" or "Revised" License
170 stars 31 forks source link

embed app not recognizing facet dimensions #165

Closed cncoleman closed 7 years ago

cncoleman commented 7 years ago

screen shot 2016-08-29 at 10 41 32 am

Note that the embed app gives the notice that dimensions are not configured for facet. Yet the code does show dimensions configured for facet. Among them is the odd "0.nm4o3xw14liqt0n0og3qh0k9"

esjewett commented 7 years ago

IIRC, there's a particular scenario in which this occurs when an invalid dimension key is somehow included in the save file for the facet filter. Which save file is this? I will take a look.

cncoleman commented 7 years ago

The missing dimension is lat lon exists. File is Voltaire Network Letters.palladio.1.2.1.json in the repo republicofletters

esjewett commented 7 years ago

Ok, looks like the save file itself is corrupt and doesn't include the proper dimension key :-/ Will try to fix, but it's probably going to involve either creating another save file after I fix Palladio or manually changing the existing one in place. Would you like me to change the current one in place?

cncoleman commented 7 years ago

sure. a fix on the current file would be the most effiencient. thanks

esjewett commented 7 years ago

Sorry I didn't update. Unfortunately I've looked further and this is a problem with the way we save and load these files, so I don't think it will be possible to just do a fix for the file in place. Working on it though...

esjewett commented 7 years ago

I've updated the palladio-embed-app to pull the latest version of Palladio, which fixes these issues in the save file and load process if you run it locally. I will also update that Palladio version in palladio-app and work to push this to the live site along with other fixes included in the 1.2.2 milestone.

You'll also see a commit coming to the republicofletters repo that will fix that load file in-place (if you use the new palladio-embed-app).

cncoleman commented 7 years ago

Super. Let me know when it's live!

esjewett commented 7 years ago

Just pushed to republicofletters, so that should work in the embed app now. You need to update the bower palladio dependency of all your applications to 1.2.2.

esjewett commented 7 years ago

Now live on the hdlab Palladio site as well, so new save files generated from here should just work.

cncoleman commented 7 years ago

Do we need to update the dependencies again in the embed app?

esjewett commented 7 years ago

Shouldn't be necessary unless you are running into the date issues that were fixed in palladio 1.2.3 (#159)