search

humanitiesplusdesign / palladio

An application that brings humanities research methods to data visualization.
BSD 3-Clause "New" or "Revised" License
170 stars 31 forks source link

Timeline issue with grouping on certain dimensions #81

Open esjewett opened 8 years ago

esjewett commented 8 years ago

To recreate:

Open the visualization view with the sample data and add a timespan and a timeline. The timespan should be birthdate on the bottom, date of death on the top. Timeline should be date of death. Group the timeline by Position. Filter the timespan to the left-most few spans. You'll see that the timeline displays a few people further to the right.

Only seems to happen for certain grouping dimensions.

esjewett commented 8 years ago

Unfortunately this is a complex issue. The grouping on the timeline calculates unique values by person/name. However if a multi-value field like Position is chosen as the grouping, only one record from each person every sees the reducers. In the case of a stacked timeline, we actually need to use the combination of the Name and the Position as the unique identifier.

I've updated the code so that we do this, but the result is then that if Position is chosen as the grouping, people with multiple positions "count" multiple times. Choose Grace Kelly in the facet view to see this.

So, still not perfect, but that behavior at least makes some modicum of sense.

I'm going to remove this issue from 1.1 but not mark it as closed for the time being.