search

humaniverse / geographr

R package for mapping UK geographies
https://humaniverse.github.io/geographr/
Other
39 stars 7 forks source link

ms_simplify() leading to issues #10

Closed MikeJohnPage closed 1 year ago

MikeJohnPage commented 3 years ago

Running rmapshaper::ms_simplify() casues rows to be dropped. This behaviour was unexpected. Look at the below example that returns dataframes of different lengths (note the call to ms_simplify is commented out in the second code block):

Screenshot 2021-07-01 at 15 05 46

We need to backtrack through all the R scripts in /data-raw and check that rows are not being dropped.

VictoriaLatham commented 1 year ago

@MikeJohnPage I also noticed this issue on the recent boundary file I added and so commented out that part of the code - really not sure why it made ~10 observations be dropped.