humanlogio / humanlog

Logs for humans to read.

Apache License 2.0

748 stars 53 forks source link

Add support for dev mode zap in docker compose #39

Closed daveworth closed 3 years ago

daveworth commented 3 years ago

This PR adds onto #37 but supporting Zap logs prefixed by Docker-Compose logs:

This patch run against Zapper running in Docker-Compose:

daveworth commented 3 years ago

@aybabtme awesome. We could also do it in one of two ways.

37 just adds plain Zap support (e.g. `go run <zap-enabled-program> 2>&1 | humanlog`). This draft PR currently is a branch from the branch in #37 so it includes both that PR's functionality and the Docker-Compose support as well.

So we could either 1. merge #37, rebase this one against master and merge it separately or 2. just merge this one and close #37. Do you have a preference? Just merging this is probably less work.

aybabtme commented 3 years ago

@daveworth sorry i just got on to this, let me know when this is ready to merge

daveworth commented 3 years ago

hey @aybabtme - I've rebased and pushed and this diff is now the right one to merge I think. Then a release and everyone can have some Zap goodness

humanlogio / humanlog

Add support for dev mode zap in docker compose #39

This patch run against Zapper running in Docker-Compose:

37 just adds plain Zap support (e.g. go run <zap-enabled-program> 2>&1 | humanlog). This draft PR currently is a branch from the branch in #37 so it includes both that PR's functionality and the Docker-Compose support as well.

37 just adds plain Zap support (e.g. `go run <zap-enabled-program> 2>&1 | humanlog`). This draft PR currently is a branch from the branch in #37 so it includes both that PR's functionality and the Docker-Compose support as well.