Force the nextrun calculation to use UTC to be consistent with the DB

humanmade / Cavalcade-Runner

Daemon for Cavalcade, a scalable WordPress jobs system.

https://engineering.hmn.md/projects/cavalcade/

54 stars 26 forks source link

Force the nextrun calculation to use UTC to be consistent with the DB #64

Closed discoinfiltrator closed 4 years ago

discoinfiltrator commented 5 years ago

Solves for: https://github.com/humanmade/Cavalcade/issues/74

discoinfiltrator commented 5 years ago

The phpcs violations are not from the file that I modified.

mackensen commented 5 years ago

This fix resolved the DST scheduling issue in our environment.

discoinfiltrator commented 4 years ago

@rmccue can this be looked at so people aren't scrambling when this comes up again in the fall?

discoinfiltrator commented 4 years ago

@rmccue @kadamwhite @missjwo what are the next steps to getting this merged? The DST switchover will be happening soon and it would be amazing to prevent this pretty brutal bug from happening to people.

discoinfiltrator commented 4 years ago

I also 100% agree that the DB, OS, PHP, etc should be using UTC - but sometimes you inherit large systems that are working with their current setup and it'd be tough to change 🙃. Thanks!