search

humanmade / Cavalcade

A better wp-cron. Horizontally scalable, works perfectly with multisite.
https://engineering.hmn.md/projects/cavalcade/
Other
512 stars 46 forks source link

Access to wp-cron.php should be disabled when Cavalcade is in use #104

Open dd32 opened 3 years ago

dd32 commented 3 years ago

Although it shouldn't happen, and should potentially be blocked at the server level, when Cavalcade is in use requests to wp-cron.php will still process any cron tasks.

As seen in #103, this currently doesn't actually work as it triggers a fatal error, but that just clouds error logs.

Ideally, Cavalcade should probably block/terminate-early the HTTP request.

roborourke commented 3 years ago

Hm, yeah you'd think setting DISABLE_WP_CRON to true would stop the file from working. Thanks for flagging this.

peterwilsoncc commented 3 years ago

This part of Cavalcade is a storage engine, it’s compatible with wp-cli, wp-cron.php, and of course the Cavalcade runner.

If you must block wp-cron.php please only do it behind the constant and make it filterable.