search

humanmade / Cavalcade

A better wp-cron. Horizontally scalable, works perfectly with multisite.
https://engineering.hmn.md/projects/cavalcade/
Other
519 stars 46 forks source link

WordPress 5.7 support #109

Closed johnbillion closed 1 year ago

johnbillion commented 3 years ago

WordPress 5.7 will allow the functions that write to the cron array to return a WP_Error object on failure. The various cron filters will also conditionally accept and return WP_Error objects. Ref: https://core.trac.wordpress.org/ticket/49961

Cavalcade should work out of the box with no changes, but it would be good to support the new $wp_error parameters and return a WP_Error instead of boolean false where necessary.

I'm happy to work on a PR.

roborourke commented 3 years ago

Thanks for flagging this @johnbillion! If you have time that'd be really helpful but seems like maintenance we'll need to for Altis v7 if you don't get to it regardless.

johnbillion commented 3 years ago

I don't think I'm going to have time for this actually. Like I said, Cavalcade will work out of the box with this change but the addition of support for optional WP_Error objects would be good.

roborourke commented 1 year ago

Fixed in #119