Remove site id from cache key missed in #26

humanmade / Cavalcade

A better wp-cron. Horizontally scalable, works perfectly with multisite.

https://engineering.hmn.md/projects/cavalcade/

Other

515 stars 46 forks source link

Closed dd32 closed 7 years ago

dd32 commented 7 years ago

When the job cache was added in #26 the site id was left in the getter, which results in the cache not being used.

tillkruss commented 7 years ago

Thanks @dd32!

dd32 commented 7 years ago

Had to push a few extra changes:

I noticed that the incorrect cache group was used (persistent vs non-persistent).
I noticed that the non-persistent cache group was being cached persistently - as the group is registered on plugins_loaded any cron operations before then would push it into the persistent cache buckets.

rmccue commented 7 years ago

Whoops, good catch!