Some basic unit tests - Githubissues

humanmade / Cavalcade

A better wp-cron. Horizontally scalable, works perfectly with multisite.

https://engineering.hmn.md/projects/cavalcade/

Other

515 stars 46 forks source link

Some basic unit tests #66

Closed peterwilsoncc closed 5 years ago

peterwilsoncc commented 5 years ago

A couple of things need fixing:

'__fake_schedule' is returned on single events instead of '', @rmccue is it a problem if these are removed from single events?
test_not_duplicate_event() event fails for some reason, needs investigating.

rmccue commented 5 years ago

'__fake_schedule' is returned on single events instead of '', @rmccue is it a problem if these are removed from single events?

Is this a regression? It should be not set or set to null IIRC

rmccue commented 5 years ago

Is this a regression? It should be not set or set to null IIRC

tl;dr no, but let's make it null for non-recurring.

peterwilsoncc commented 5 years ago

@rmccue

The core cron test suite now passes with Cavalcade, changes in this PR:

Add core test suite
Removed sniffs because they're not passing
cron array is key sorted to ensure it's returned in the correct order.
schedule defaults to false to match core

peterwilsoncc commented 5 years ago

The test suite install only downloads the required directories from WP Core's suite (includes and data) so I've added an extra step to download the cron tests and copy it into the Cavalcade test directory.