search

humanmade / Cavalcade

A better wp-cron. Horizontally scalable, works perfectly with multisite.
https://engineering.hmn.md/projects/cavalcade/
Other
512 stars 46 forks source link

Fix Travis tests #90

Closed roborourke closed 4 years ago

roborourke commented 4 years ago

An update to Travis meant we need to specify mysql under the services property now. This should fix the builds.

roborourke commented 4 years ago

So the tests are running again but with failures, was that the case before?

roborourke commented 4 years ago 
1) Tests_Cron::test_schedule_event_single
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:45
2) Tests_Cron::test_schedule_event_single_args
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:60
3) Tests_Cron::test_schedule_event
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:78
4) Tests_Cron::test_schedule_event_args
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:93
5) Tests_Cron::test_unschedule_event
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:114
6) Tests_Cron::test_clear_schedule
Failed asserting that false is identical to 2.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:134
7) Tests_Cron::test_unschedule_hook
Failed asserting that false is identical to 4.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:240
8) Tests_Cron::test_duplicate_event
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:273
9) Tests_Cron::test_not_duplicate_event
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:292
10) Tests_Cron::test_not_duplicate_event_reversed
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:311
11) Tests_Cron::test_pre_reschedule_event_filter
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:385
12) Tests_Cron::test_pre_unschedule_event_filter
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:409
13) Tests_Cron::test_pre_clear_scheduled_hook_filters
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:433
14) Tests_Cron::test_duplicate_past_event
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:613
15) Tests_Cron::test_duplicate_near_future_event
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:635
16) Tests_Cron::test_duplicate_future_event
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:657
17) Tests_Cron::test_not_duplicate_future_event
Failed asserting that false is true.
/home/travis/build/humanmade/Cavalcade/tests/class-wp-core-cron.php:677
roborourke commented 4 years ago

@rmccue maybe the core update_option() function changed but basically the core cron tests never pass as Cavalcade intentionally short circuits saving to the db, this means update_option() returns false and a bunch of asserts fail, there's no way around it. Think we need to remove them.

roborourke commented 4 years ago

Core tests won't pass until #75 is merged, so this at least gets them to the point of running phpunit again with the right version