humanmade / S3-Uploads

The WordPress Plugin to Store Uploads on Amazon S3
1.92k stars 389 forks source link

Use get_temp_dir instead of sys_get_temp_dir #655

Closed ajakov closed 5 months ago

ajakov commented 10 months ago

I had a problem on one of the WordPress installation where directory returned by sys_get_temp_dir was not writeable by php and changing WP_TEMP_DIR did not help (because the plugin was not taking that into account).
Changing sys_get_temp_dir to Wordpress function get_temp_dir helped.

tomjn commented 10 months ago

This PR makes sense to me, I'll hold off approving though as I'm not super familiar with this code