search

humanmade / Salty-WordPress

A flavorful way to manage your entire WordPress stack.
126 stars 22 forks source link

Dev only plugins #114

Closed roborourke closed 9 years ago

roborourke commented 9 years ago

Thanks to some tips from @joehoyle I got this working. I've submoduled in a bunch of useful plugins and they all seem to work, only thing is I'm wondering whether to uncomment the code that would run the activation hooks for each one. Not sure that;s a good idea but would be good to get some feedback.

danielbachhuber commented 9 years ago

Why did you go with submodules instead of installing via WP-CLI?

Personally, I think submodules are a PITA and it's better to just install when you can.

joehoyle commented 9 years ago

@danielbachhuber does wp-cli support installing plugins from a git repo or something, or do they have to be on wp.org?

roborourke commented 9 years ago

I'd say think of this as a proof of concept for now, it'll need some fine tuning.

@danielbachhuber happy to remove the submodules, agree they can be a pain though I've finally got my head round them. We could just remove them and not package anything, let people install what they want there.

danielbachhuber commented 9 years ago

does wp-cli support installing plugins from a git repo or something, or do they have to be on wp.org?

WP.org right now: https://github.com/wp-cli/wp-cli/issues/1557

willmot commented 9 years ago

@missjwo was this merged intentionally? If so was their a conversation / consensus that it should be merged? Could you crosspost that here if so

missjwo commented 9 years ago

@willmot No, I didnt even realise i had done that. I think i was pushing something up to a community project. Must have been in the wrong folder :/

willmot commented 9 years ago

@joehoyle @danielbachhuber do we need to revert this?

danielbachhuber commented 9 years ago

Yes. I don't have a strong opinion one way or another about dev plugins generally, but there's code that snuck in that shouldn't have.

I don't have a revert button though:

image

willmot commented 9 years ago

hmm yeah me neither @missjwo do you have a revert button?

willmot commented 9 years ago

Actually I think this is a Github booboo, I don't see any merge commits into master and this branch is still reporting as being 4 commits ahead.

missjwo commented 9 years ago

@willmot @danielbachhuber I dont have the revert button. I've reverted it locally and checked the files and it's all fine here.

@sanchothefat said that he forced master back to the commit before his stuff and was going to create a new PR request.

danielbachhuber commented 9 years ago

Sounds good, thanks @missjwo