search

humanmade / Salty-WordPress

A flavorful way to manage your entire WordPress stack.
126 stars 22 forks source link

Set value for SERVER_NAME #124

Closed pdewouters closed 8 years ago

pdewouters commented 8 years ago
screenshot 2015-11-10 10 00 29

As far as I understand, this should be set in the fastcgi_params file which is included here: https://github.com/humanmade/Salty-WordPress/blob/master/config/salt/config/nginx/default#L75

I created that file in the same folder locally and added fastcgi_param SERVER_NAME $host; But on vagrant reload it hasn't changed the value. Am I doing it wrong?

roborourke commented 8 years ago

@pdewouters you'd have to re-provision too to make any managed files stick, I'll try this on mine

roborourke commented 8 years ago

@joehoyle Tested locally and this works fine, any issues with it being implemented on our main stack? Would avoid those problems with code that relies on $_SERVER['SERVER_NAME'] rather than $_SERVER['HTTP_HOST'] like the comment notification functions in core

pdewouters commented 8 years ago

ah I didn't re-provision.

pdewouters commented 8 years ago

couldn't get xdebug to connect. do you set the remote PHP interpreter?

paulgibbs commented 8 years ago

Tested locally and works well.