search

humanmade / Simple-Instant-Articles-for-Facebook

Add support for Facebook Instant Articles to your WordPress site.
7 stars 0 forks source link

LAW-310: Add FB script to each embed iframe #51

Closed dashaluna closed 8 years ago

dashaluna commented 8 years ago

@mattheu the script is now inserted into each iframe for FB embed. However, they don't seem to work. Not sure what I'm missing. Could you please have a look?

mattheu commented 8 years ago

OK I looked into this a little bit

  1. Confirmed it doesn't work. FB complains about the <post> tag jetpack is outputting.
  2. WP.com embeds DO NOT use the same markup. Adding our script hack to these embeds works great!

Not sure what to do here. We don't know what the embed logic is on .com. We could open a ticket on zendesk and ask for help?

dashaluna commented 8 years ago

Let's ask - it would be good to know what's going on!

dashaluna commented 8 years ago

Closing in favour of https://github.com/humanmade/Simple-Instant-Articles-for-Facebook/pull/52