search

humanmade / Simple-Instant-Articles-for-Facebook

Add support for Facebook Instant Articles to your WordPress site.
7 stars 0 forks source link

Fix matching of double iframe-d embeds #77

Closed dashaluna closed 8 years ago

dashaluna commented 8 years ago

…e both social and interactive

dashaluna commented 8 years ago

@mattheu we use op-social and op-interactive. I went with using starts-with(@class, \'op-\') because xpath in general is quite specific and starts-with makes it easier to read, than listing both classes in full.

dashaluna commented 8 years ago

@mattheu do you think starts-with(@class, \'op-\') can also be used here? https://github.com/humanmade/Simple-Instant-Articles-for-Facebook/pull/77/files#diff-0224030e3568f4929a251485a52246abL465

mattheu commented 8 years ago

oh didn't know you could do that. Yeah looks good. :+1: